Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test timeout to 1000 ms #287

Merged
merged 1 commit into from Mar 26, 2017
Merged

Update test timeout to 1000 ms #287

merged 1 commit into from Mar 26, 2017

Conversation

tomas-pluskal
Copy link
Contributor

Hope this fixes #285

@egonw
Copy link
Member

egonw commented Mar 26, 2017

OK, yes, that should do it too. I was kinda hoping that preloading the class it is busy with loading would solve it more nicely...

@egonw egonw merged commit 3ef841d into cdk:master Mar 26, 2017
@tomas-pluskal tomas-pluskal deleted the patch-4 branch March 26, 2017 15:52
@johnmay
Copy link
Member

johnmay commented Mar 26, 2017

-1

@egonw
Copy link
Member

egonw commented Mar 26, 2017

Shall I revert the patch, so that we can think of a better way of fixing the regression?

Who approved that test in the first place?? ;)

@johnmay
Copy link
Member

johnmay commented Mar 26, 2017

It's fine, I just don't like it :-). As it's in a test I'm not really bothered.

@egonw
Copy link
Member

egonw commented Mar 26, 2017

Agreed... see my comments that I had hoped for a more elegant fix... but cannot think of one right now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timing regression in the MF generator
3 participants