Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-4_x: 4.6.0 -> 4.8.1 #24329

Merged
merged 1 commit into from Mar 25, 2017
Merged

nodejs-4_x: 4.6.0 -> 4.8.1 #24329

merged 1 commit into from Mar 25, 2017

Conversation

cko
Copy link
Member

@cko cko commented Mar 25, 2017 •
edited by LnL7

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@cko, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LnL7, @gilligan and @FRidh to be potential reviewers.

@LnL7 LnL7 merged commit f422543 into NixOS:master Mar 25, 2017
@LnL7 LnL7 mentioned this pull request Mar 25, 2017
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cko @mention-bot @matthiasbeyer @LnL7