Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vis: 2016-10-09 -> 0.3 #24356

Merged
merged 2 commits into from Mar 31, 2017
Merged

vis: 2016-10-09 -> 0.3 #24356

merged 2 commits into from Mar 31, 2017

Conversation

vrthra
Copy link
Member

@vrthra vrthra commented Mar 26, 2017

Motivation for this change

Switching from unstable to real version since the developer has published a new version after a long time.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vrthra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @RamKromberg and @dezgeg to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Mar 26, 2017 •
edited

when starting vis, I get the following error message:

WARNING: could not find lpeg module

and

...n108110arbn9d9h-vis-0.3/share/vis/themes/default-256.lua:23: attempt to index local 'lexers' (a nil value)

Those errors sounds related to me (lpeg is a parser library).

@vrthra
Copy link
Member Author

vrthra commented Mar 26, 2017

@Mic92 which OS? and are you using a configuration file? Any other details? I am running on NixOS, and I don't seem to have any error on startup.

@fpletz
Copy link
Member

fpletz commented Mar 26, 2017

Weird, works for me.

@Mic92
Copy link
Member

Mic92 commented Mar 26, 2017 •
edited

If I use:

$ nix-shell --pure -p vis

it works.

Looks like awesome wm taints my environment with LUA_CPATH:

LUA_CPATH=/nix/store/1vx62526wx0a78339217jp07py7yq8vw-lgi-0.9.1/lib/lua/5.2/?.so;/nix/store/dmjcdfdyr5plkcn7w2hhpifr75drwn0z-lua5.2-socket-3.0-rc1/lib/lua/5.2/?.so;/nix/store/dmjcdfdyr5plkcn7
w2hhpifr75drwn0z-lua5.2-socket-3.0-rc1/share/lua/5.2/?.so

@Mic92
Copy link
Member

Mic92 commented Mar 26, 2017

This package was using : instead of ; to prefix the lua search path. This fix should be also backported.

@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 26, 2017
@vrthra
Copy link
Member Author

vrthra commented Mar 27, 2017

@Mic92 which branch should this be backported to?

@Mic92 Mic92 merged commit a16c2e5 into NixOS:master Mar 31, 2017
@Mic92
Copy link
Member

Mic92 commented Mar 31, 2017

17.03

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vrthra @mention-bot @Mic92 @fpletz @pSub @samueldr