Abstract Trajectory #1289
Merged
Abstract Trajectory #1289
+162
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Mar 26, 2017
physics/continuous_trajectory.hpp
Outdated
| Hint* hint) const; | ||
| // Implementation of the interface |Trajectory|. | ||
|
|
||
| using TrajectoryHint = Trajectory<Frame>::Hint; |
There was a problem hiding this comment.
I don't like this name, I'd rather have Trajectory<Frame>::Hint in the few places where it's used.
| CHECK(it != series_.end()); | ||
| if (hint != nullptr) { | ||
| hint->index_ = it - series_.cbegin(); | ||
| Trajectory<Frame>::Hint* const hint) const { |
There was a problem hiding this comment.
See? Trajectory<Frame>::Hint is much better than TrajectoryHint.
physics/trajectory.hpp
Outdated
| virtual Instant t_max() const = 0; | ||
|
|
||
| // Gets a |Hint| of the appropriate derived type. | ||
| virtual not_null<std::unique_ptr<Hint>> GetHint() const = 0; |
There was a problem hiding this comment.
Call this NewHint, it makes it clearer that this is a factory. Otherwise one is left wondering where it "gets" it from.
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two interfaces.