Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamlink: 0.3.0 -> 0.5.0 #24884

Closed
wants to merge 3 commits into from
Closed

streamlink: 0.3.0 -> 0.5.0 #24884

wants to merge 3 commits into from

Conversation

zraexy
Copy link
Member

@zraexy zraexy commented Apr 13, 2017

Motivation for this change

Update streamlink to the latest version
It now requires iso-639 and iso3166 for localization.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@zraexy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg, @yorickvP and @FRidh to be potential reviewers.

@Mic92 Mic92 closed this in a7d2be1 Apr 16, 2017
@FRidh
Copy link
Member

FRidh commented Apr 17, 2017

this PR contains some other commits. What's happened with those?

@zraexy
Copy link
Member Author

zraexy commented Apr 17, 2017

@FRidh They were committed: 62b1bd1 51770c8 It just doesn't show up for some reason.

@Mic92
Copy link
Member

Mic92 commented Apr 17, 2017

@FRidh I pushed them together with my own commit directly to master. My commit also closed this pullrequest.

@zraexy zraexy deleted the streamlink branch April 25, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants