New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grub: Bump to 2.02-rc2 #24451
grub: Bump to 2.02-rc2 #24451
Conversation
@Baughn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @dezgeg and @fpletz to be potential reviewers. |
I'm not sure what the unifont code was about, so I deleted it, and grub appears to work just as well as before. Ideally we'd get input from the guy who added it before merging, however. |
The unifont was added by @civodul 8 years before. But this account does not look to active. |
I did see that unifont code affecting the configure script (in #22923). I'm guessing that it still works for most text without unifont but you don't see Unicode characters without it. As a data point, Arch Linux also does the unifont dance: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/grub |
Ok, I'll make sure to test that, and perhaps revert the deletion. Will check back in ~eight hours. |
@Baughn any updates? |
Right, updates. How do you feel about "I only imagined grub working with NVMe"? Or rather, it only worked in a legacy bios configuration, which I can't use for other reasons. I've taken a few pokes at it since, but I have no idea what I'm doing, and updating it doesn't seem to offer any benefit. |
Ouch. So you were less lucky than the reporter of https://savannah.gnu.org/bugs/?41883 |
Looking at the git tags, there seems to be a final GRUB 2.02?! (https://git.savannah.gnu.org/cgit/grub.git/tag/?h=grub-2.02) |
The installer tests fail due to missing unifont. |
Motivation for this change
This allows grub2 to work on (at least some) nvme devices.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)