Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub: Bump to 2.02-rc2 #24451

Closed
wants to merge 1 commit into from
Closed

grub: Bump to 2.02-rc2 #24451

wants to merge 1 commit into from

Conversation

Baughn
Copy link
Contributor

@Baughn Baughn commented Mar 29, 2017

Motivation for this change

This allows grub2 to work on (at least some) nvme devices.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Baughn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @dezgeg and @fpletz to be potential reviewers.

@Baughn
Copy link
Contributor Author

Baughn commented Mar 29, 2017

I'm not sure what the unifont code was about, so I deleted it, and grub appears to work just as well as before. Ideally we'd get input from the guy who added it before merging, however.

@Mic92
Copy link
Member

Mic92 commented Mar 30, 2017

The unifont was added by @civodul 8 years before. But this account does not look to active.

@dezgeg
Copy link
Contributor

dezgeg commented Mar 30, 2017

I did see that unifont code affecting the configure script (in #22923). I'm guessing that it still works for most text without unifont but you don't see Unicode characters without it.

As a data point, Arch Linux also does the unifont dance: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/grub

@Baughn
Copy link
Contributor Author

Baughn commented Mar 30, 2017

Ok, I'll make sure to test that, and perhaps revert the deletion. Will check back in ~eight hours.

@7c6f434c
Copy link
Member

7c6f434c commented May 1, 2017

@Baughn any updates?

@Baughn
Copy link
Contributor Author

Baughn commented May 13, 2017

Right, updates. How do you feel about "I only imagined grub working with NVMe"?

Or rather, it only worked in a legacy bios configuration, which I can't use for other reasons. I've taken a few pokes at it since, but I have no idea what I'm doing, and updating it doesn't seem to offer any benefit.

@7c6f434c
Copy link
Member

Ouch. So you were less lucky than the reporter of https://savannah.gnu.org/bugs/?41883

@globin globin added this to the 17.09 milestone Aug 11, 2017
@NeQuissimus
Copy link
Member

Looking at the git tags, there seems to be a final GRUB 2.02?! (https://git.savannah.gnu.org/cgit/grub.git/tag/?h=grub-2.02)
Did you give that a try at all?

@fpletz
Copy link
Member

fpletz commented Aug 13, 2017

The installer tests fail due to missing unifont.

@fpletz fpletz self-assigned this Aug 13, 2017
@fpletz fpletz closed this in 3317c71 Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants