bitlbee-facebook: 2015-08-27 → 1.1.0 #24454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michalrus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @anderspapitto and @dezgeg to be potential reviewers. |
michalrus
changed the title
michalrus
force-pushed
the
bitlbee-facebook
branch
from
f026a9d
to
20772c6
Compare
ndowens
reviewed
Mar 29, 2017
| owner = "jgeboski"; | ||
| repo = "bitlbee-facebook"; | ||
| sha256 = "1dvbl1z6fl3wswvqbs82vkqlggk24dyi8w7cmm5jh1fmaznmwqrl"; | ||
| sha256 = "0qclyc2zz8144dc42bhfv2xxrahpiv9j2iwq9h3cmfxszvkb8r3s"; | ||
| }; | ||
|
|
||
| buildInputs = [ bitlbee autoconf automake libtool pkgconfig glib json_glib ]; |
There was a problem hiding this comment.
Move: autoconf, automake, libtool pkgconfig into nativeBuildInputs
michalrus
force-pushed
the
bitlbee-facebook
branch
from
20772c6
to
2cef2c5
Compare
|
Thanks! |
|
I suppose this should be also back ported? |
Mic92
added
the
9.needs: port to stable
|
@Mic92, possibly, yes. Because all older versions won’t work at all, after the protocol change. Or you can copy my approach to |
Mic92
pushed a commit
that referenced
this pull request
Mar 30, 2017
(cherry picked from commit 2cef2c5) backported because not functional due protocol changes: #24454 (comment)
|
I included this change in 17.03. |
samueldr
removed
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The previous one stopped working after Facebook’s updates, see bitlbee/bitlbee-facebook#138
Things done
nix-shell -p nox --run "nox-review wip"./result/bin/)