python-packages: add flask-openid package and dependencies #24458
Conversation
pkgs/top-level/python-packages.nix
Outdated
| @@ -8556,6 +8556,25 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| python-openid = buildPythonPackage rec { | |||
There was a problem hiding this comment.
Because of the size of this file, we are currently moving all new python packages to: pkgs/development/python-modules/
e.x: pkgs/development/python-modules/python-openid/default.nix
pkgs/top-level/python-packages.nix
Outdated
| # use python3-openid instead | ||
| disabled = isPy3k; | ||
|
|
||
| src = pkgs.fetchurl { |
There was a problem hiding this comment.
We also start using fetchPypi here, whenever possible.
pkgs/top-level/python-packages.nix
Outdated
| meta = { | ||
| description = "OpenID support for servers and consumers"; | ||
| homepage = "https://github.com/openid/python-openid"; | ||
| license = licenses.asl20; |
There was a problem hiding this comment.
Do you want to maintain this package?
There was a problem hiding this comment.
Of all packages I've contributed, this is probably the one I'm least suitable to maintain...
|
Ok should be good now. |
|
So that's three new packages without maintainer and without any tests? You do realize that if someone updates any of these packages' dependencies that that might break your packages? |
|
So this PR is actually a result of my intention to package Flask-AppBuilder (which does have some sensible tests), but Flask-AppBuilder's requirements pinning specific versions of Flask-SQLAlchemy and Flask-Login would seem to make that tricky - the question is whether there is any value in sharing the parts of that branch that were usable...? (namedly the Flask-OpenID package & deps - issue is that I'm not actually a user of the openid parts myself) Or with the advent of (I could of course make a bigger effort at tracking down |
Each package that is added to the package set adds maintenance. I prefer to only add packages that have (active) maintainers. |
|
Cool, let's close this. |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)