Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projectlibre: init at 1.6.2 #24466

Closed
wants to merge 3 commits into from
Closed

projectlibre: init at 1.6.2 #24466

wants to merge 3 commits into from

Conversation

mogria
Copy link
Contributor

@mogria mogria commented Mar 30, 2017

Motivation for this change

Alternative to ganttproject with more features. More similar to MS-Project.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@mogria, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @edolstra and @peti to be potential reviewers.

meta = with stdenv.lib; {
homepage = "http://www.projectlibre.com/";
descripton = "Project-Management Software similar to MS-Project";
maintainer = with maintainers; [ mogria ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use maintainer.mogria instead as with maintainers is used for more than one maintainers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I push another commit or force push to my branch?

@joachifm
Copy link
Contributor

Travis fails with

building path(s) ‘/nix/store/8rm3nlh7zniz8vb5p6ajqhgwsg81lzzk-code’
exporting https://git.code.sf.net/p/projectlibre/code (rev v1.6.2) into /nix/store/8rm3nlh7zniz8vb5p6ajqhgwsg81lzzk-code
Bad commit hash or bad reference.

I believe it's because v is prepended to the revision passed to fetchgit.


src = fetchgit {
url = "https://git.code.sf.net/p/projectlibre/code";
rev = "v${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try something like refs/tags/v${version} instead

mogria added a commit to mogria/nixpkgs that referenced this pull request Apr 12, 2017
@mogria
Copy link
Contributor Author

mogria commented Apr 18, 2017

Is there still any issue with this?

@vcunat
Copy link
Member

vcunat commented Apr 30, 2017

There are minor problems in meta (description, maintainers = [ maintainers.mogria ]),

but the main problem I see is that it won't start unless you have some java binaries on $PATH:

$ ./result/bin/projectlibre 
Java auto-detection...
Checking java
    Error
Java not found or incorrect version.
Please install OpenJDK, Oracle JRE 1.6+ or set JAVA_HOME environment variable if it's already installed.

@vcunat
Copy link
Member

vcunat commented Apr 30, 2017

Well, even if I do that, the displayed window is strangely empty – I created a new project and tried adding a few items, but all I'm getting is an all-gray window without anything really displayed.

@joachifm
Copy link
Contributor

So, does this work as packaged or not?

@joachifm joachifm mentioned this pull request Dec 11, 2017
8 tasks
@bjornfor
Copy link
Contributor

Running with empty PATH reveals some missing dependencies:

$ PATH= ./result/bin/projectlibre 
./result/bin/projectlibre: line 85: uname: No such file or directory
./result/bin/projectlibre: line 171: java: No such file or directory
Java auto-detection...
Checking java
./result/bin/projectlibre: line 124: rm: No such file or directory
./result/bin/projectlibre: line 127: cat: No such file or directory
./result/bin/projectlibre: line 127: awk: No such file or directory
    Java version:  ./result/bin/projectlibre: line 136: sed: No such file or directory
./result/bin/projectlibre: line 137: sed: No such file or directory
./result/bin/projectlibre: line 137: awk: No such file or directory
NOK
Java not found or incorrect version.
Please install OpenJDK, Oracle JRE 1.6+ or set JAVA_HOME environment variable if it's already installed.

Also, the path to java seems to be stored in ~/.projectlibre/run.conf. I'm not sure if that path gets updated on every run, but just in case, I'd pass only program names to projectlibre, instead of full nix store paths. (Or else things may break when updating / garbage collecting.)

Injecting export "PATH=${jre}/bin:${coreutils}/bin:${which}/bin:\$PATH" into the startup script should suffice. (Adding "impure" $PATH to the end because projectlibre may want to start your $BROWSER.)

Lastly, @mogria, would you mind interactively rebasing the PR so that the commit sequence is:

  1. add license
  2. add maintainer
  3. add package

Thanks!

@bjornfor
Copy link
Contributor

And please update to version 1.7.0.

@bjornfor
Copy link
Contributor

bjornfor commented Mar 1, 2018

@mogria: Ping?

Moritz Küttel added 3 commits March 7, 2018 21:15
The 'Common Public Attribution License 1.0' is used
for projectlibre and required for packaging it into nixpkgs.
@mogria mogria requested review from edolstra and nbp as code owners March 8, 2018 09:43
@obadz obadz closed this in 18ea001 Mar 18, 2018
dotlambda pushed a commit that referenced this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants