Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename secure_random.cr to securerandom.cr for keep same behavior as Ruby #4213

Closed
wants to merge 1 commit into from
Closed

Rename secure_random.cr to securerandom.cr for keep same behavior as Ruby #4213

wants to merge 1 commit into from

Conversation

huacnlee
Copy link

https://ruby-doc.org/stdlib-2.3.0/libdoc/securerandom/rdoc/SecureRandom.html

require "securerandom"
# not require "secure_random"

I don't know reason Ruby is use that name, but I thinks to keep the same filename it better for when a new Ruby developer to try uses require it.

@huacnlee
Rename secure_random.cr to securerandom.cr for keep same behavior…
9f6a7e6 
… as Ruby.

```cr
require "securerandom"
```
@ysbaddaden
Copy link
Contributor

Sorry, consistency in file naming in Crystal is a fix of Ruby weirdness. Just as you point out: it's better.

@ysbaddaden ysbaddaden closed this Mar 30, 2017
@huacnlee
Copy link
Author

😄

@huacnlee huacnlee deleted the rename-securerandom branch March 30, 2017 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huacnlee @ysbaddaden