Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grub module: fix efiInstallAsRemovable description #24978

Merged
merged 1 commit into from Apr 17, 2017
Merged

grub module: fix efiInstallAsRemovable description #24978

merged 1 commit into from Apr 17, 2017

Conversation

zraexy
Copy link
Member

@zraexy zraexy commented Apr 17, 2017

Motivation for this change

https://nixos.org/nixos/options.html#boot.loader.grub.efiinstallasremovable currently errors and fails to display option info when clicked on.
Adds missing opening tag for the first paragraph and closing tag for the last one.
This should be backported to 17.03

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@zraexy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @wkennington and @obadz to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Apr 17, 2017

Thanks!

@Mic92 Mic92 merged commit 6e63f41 into NixOS:master Apr 17, 2017
@zraexy
Copy link
Member Author

zraexy commented Apr 18, 2017

Hydra builds are now failing. I believe it is the same issue as: #22815

@zraexy zraexy mentioned this pull request Apr 18, 2017
Closed
7 tasks
vcunat added a commit that referenced this pull request Apr 18, 2017
@vcunat
Revert "grub module: fix efiInstallAsRemovable description"
91ad6b3 
This reverts commit c2b5662.
It broke creating the manual.  I suspect the descriptions are
auto-wrapped by <para> and </para>.

We've been through this already in 3af715a.
/cc #24978, @zraexy, @Mic92.
vcunat added a commit that referenced this pull request Apr 18, 2017
@vcunat
Revert "grub module: fix efiInstallAsRemovable description"
b22029d 
This reverts commit c2b5662.
It broke creating the manual.  I suspect the descriptions are
auto-wrapped by <para> and </para>.

We've been through this already in 3af715a.
/cc #24978, @zraexy, @Mic92.

(cherry picked from commit 91ad6b3)
FRidh pushed a commit that referenced this pull request Apr 18, 2017
@vcunat @FRidh
Revert "grub module: fix efiInstallAsRemovable description"
f35f063 
This reverts commit c2b5662.
It broke creating the manual.  I suspect the descriptions are
auto-wrapped by <para> and </para>.

We've been through this already in 3af715a.
/cc #24978, @zraexy, @Mic92.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zraexy @mention-bot @Mic92