Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop THEME_REVEAL_CONFIG_* settings (#2485) #2723

Merged
merged 2 commits into from May 12, 2017
Merged

Drop THEME_REVEAL_CONFIG_* settings (#2485) #2723

merged 2 commits into from May 12, 2017

Conversation

Kwpolska
Copy link
Member

This is part of #2485, and it removes THEME_REVEAL_CONFIG_* from everywhere, unless the user has them. The global context should be used in the long term.

@Kwpolska
Drop THEME_REVEAL_CONFIG_* settings (#2485)
5f2e302 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added the minor label Apr 17, 2017
@Kwpolska Kwpolska added this to the v7.8.5 milestone Apr 17, 2017
felixfontein
felixfontein approved these changes Apr 19, 2017
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kwpolska Kwpolska requested a review from ralsina April 19, 2017 18:54
ralsina
ralsina approved these changes May 12, 2017
View reviewed changes
Copy link
Member

@ralsina ralsina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ralsina ralsina merged commit 5246265 into master May 12, 2017
@ralsina ralsina deleted the drop-reveal-theme-settings branch May 12, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralsina ralsina ralsina approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
v7.8.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kwpolska @ralsina @felixfontein