Fully honor no color option when running specs #4306
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec runner have the option to disable colored output (ANSI codes) when
`--no-color` option is used, example:
$ crystal spec -- --no-color
However, certain elements in the output didn't fully support that option,
resulting in a mix of non-color and color.
This change unifies that setting and ensures that `--no-color` usage
is fully honored by the output.
Ref #4292
bcardiff
added
kind:bug
|
Awesome! Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec runner have the option to disable colored output (ANSI codes) when
--no-coloroption is used, example:However, certain elements in the output didn't fully support that option, resulting in a mix of non-color and color:
This change unifies that setting and ensures that
--no-colorusage is fully honored by the output:Ref #4292
Thank you. ❤️ ❤️ ❤️