Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultIconTheme: Enable darwin support #24976

Merged
merged 1 commit into from Apr 18, 2017
Merged

defaultIconTheme: Enable darwin support #24976

merged 1 commit into from Apr 18, 2017

Conversation

hamishmack
Copy link
Contributor

Motivation for this change

Make gnome3.defaultIconTheme work on macOS

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 added the 6.topic: darwin Running or building packages on Darwin label Apr 17, 2017
@LnL7 LnL7 merged commit da811a5 into NixOS:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hamishmack @LnL7 @Mic92