Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring shader bug fix #165

Closed
wants to merge 2 commits into from
Closed

Ring shader bug fix #165

wants to merge 2 commits into from

Conversation

LGhassen
Copy link
Contributor

@LGhassen LGhassen commented Apr 4, 2017

Hello,

This fixes the issue with the new ring shader not appearing on some bodies. I also added the shader compilation cache and log files to the .gitignore

-blackrack

@Poodmund
Copy link

Poodmund commented Apr 4, 2017

The issue was that when the new ring shader was used, it didn't display properly when used on more than one body.

The above commits seem to fix this issue.

@LGhassen
Copy link
Contributor Author

LGhassen commented Apr 4, 2017

Actually Pood, from my testing the other day, the number of actual bodies using rings didn't seem to matter, specific bodies get it anyway, even if they're the only one with rings. Anyway, if it's fixed, it's fixed.

@StollD
Copy link
Member

StollD commented Apr 5, 2017

Thank you @LGhassen

I am going to merge this manually, pull requests should go against development (/me slaps himself for not adding a CONTRIBUTING.md), and they shouldnt contain compiled binaries, since those are built by Jenkins.
So more my fault than yours. ;)

@StollD StollD closed this Apr 5, 2017
@StollD
Copy link
Member

StollD commented Apr 5, 2017

Merged manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants