Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-packages: factor package set construction into new file #24850

Closed
wants to merge 1 commit into from
Closed

haskell-packages: factor package set construction into new file #24850

wants to merge 1 commit into from

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Apr 12, 2017

This makes it a lot easier to replace the haskell-packages.nix used in nixpkgs while still using all the infrastructure that is available. Example:

let
  pkgs = import <nixpkgs> {};
  conf-set = import ./configuration-packages.nix { inherit pkgs; };
  conf-nix = import <nixpkgs/pkgs/development/haskell-modules/configuration-nix.nix> { inherit pkgs; };
  inherit (pkgs.lib) fix' extends makeExtensible;
  pkgset = pkgs.haskell.lib.makePackageSet {
    ghc = pkgs.haskell.compiler.ghc802;
    package-set = import ./packages.nix;
  };
in makeExtensible (extends conf-set (extends conf-nix pkgset))

@bennofs bennofs requested a review from peti April 12, 2017 17:38
@mention-bot
Copy link

@bennofs, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @oxij and @3noch to be potential reviewers.

peti pushed a commit to peti/nixpkgs that referenced this pull request Apr 21, 2017
@bennofs @peti
haskell-packages: factor package set construction in new file
c48ebe3 
Closes NixOS#24850.
@peti
Copy link
Member

peti commented Apr 21, 2017

Merged to haskell-updates for build-testing in c48ebe3.

@peti peti closed this in 5f33eb4 Apr 21, 2017
@bennofs bennofs deleted the haskell-make-package-set branch April 21, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bennofs @mention-bot @peti