Deduplicate math code and include KaTeX CSS automatically when needed #2717
Conversation
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
LGTM! |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
I’d like to request another review, since I changed quite a few more things. |
| @@ -0,0 +1,58 @@ | |||
| {% macro math_scripts() %} | |||
There was a problem hiding this comment.
How about adding two macros (one for KaTeX, one for MathJax) which provide the version number for each of them?
There was a problem hiding this comment.
Not possible since we’re using checksums.
There was a problem hiding this comment.
Ah, I overlooked that.
nikola/conf.py.in
Outdated
| @@ -972,13 +974,10 @@ PRETTY_URLS = ${PRETTY_URLS} | |||
|
|
|||
| # Want to use KaTeX instead of MathJax? While KaTeX is less featureful, | |||
| # it's faster and the output looks better. | |||
| # If you set USE_KATEX to True, you also need to add an extra CSS file like | |||
| # this: (make sure to match the version Nikola uses -- check it in HTML output) | |||
| # EXTRA_HEAD_DATA = """<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/KaTeX/0.7.1/katex.min.css" integrity="sha384-wITovz90syo1dJWVh32uuETPVEtGigN07tkttEqPv+uR2SE/mbQcG7ATL28aI9H0" crossorigin="anonymous">""" | |||
There was a problem hiding this comment.
Maybe we should add some code in Nikola.__init__ which checks for "KaTeX/0.7.1/katex.min.css" in self.config["EXTRA_HEAD_DATA"] and informs the user about these changes, in case they missed the changelog?
There was a problem hiding this comment.
Sure, will do. (It won’t ever be 0.7.1 in a user config, because that was only a stopgap change)
h/t @felixfontein Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
This is #2715.