vscode: Fix relocation errors #24509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not entirely sure if it was built in a sandbox. I'm on NixOS with |
LD_PRELOAD was inherited by spawned processes, and caused issues with systems that have older system packages while using fresh user packages. Links out the wrapper script instead of electron binary to expose CLI like on other systems Breaks anything that relies on vscode not detaching
tilpner
changed the title
|
Works great for me. Much improved. |
|
all nix commands obey /etc/nix/nix.conf, so it wont matter which one you used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LD_PRELOAD was inherited by spawned processes, and caused
issues with systems that have older system packages while
using fresh user packages (very similar to a4d6e2c)
Links out the wrapper script instead of electron binary to
expose CLI like on other systems
Breaks anything that relies on vscode not detaching
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)