Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmtp: fix the Using the 'memory' GSettings backend issue. #24602

Closed
wants to merge 1 commit into from
Closed

gmtp: fix the Using the 'memory' GSettings backend issue. #24602

wants to merge 1 commit into from

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Apr 3, 2017

Motivation for this change

gmtp unable to save its settings.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@abbradar
Copy link
Member

abbradar commented Apr 4, 2017

Please use wrapGAppsHook instead - it automatically adds dconf, too (you don't need to specify it explicitly).

@abbradar
Copy link
Member

abbradar commented Apr 4, 2017

I was going to sleep and didn't notice that it already uses wrapGAppsHook, sorry. We have recently made it so wrapGAppsHook automatically adds dconf as necessary; have you seen if the latest channel works for you?

@Mic92
Copy link
Member

Mic92 commented Apr 4, 2017 •
edited

When I read the code of wrap-gapps-hook.sh it still requires dconf as a buildInput when wrapGAppsHook is used.

Yes, the warning goes away, when adding dconf to buildInputs to the baobab package.

@abbradar
Copy link
Member

abbradar commented Apr 4, 2017 via email

@Mic92 Mic92 mentioned this pull request Apr 4, 2017
Merged
7 tasks
@pbogdan
Copy link
Member Author

pbogdan commented Apr 4, 2017

This is totally my bad, I just tested again against latest unstable channel and indeed everything works when using wrapGAppsHook so no changes are needed. Thank you for catching that and sorry for the noise.

@pbogdan pbogdan closed this Apr 4, 2017
@pbogdan pbogdan deleted the gmtp branch December 3, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @abbradar @Mic92