Mumble_git (and murmur_git): 2016-04-10 -> 2017-04-02 #24605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also marked murmur_git as unbroken, as long as iceSupport is disabled.
|
@teozkr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @abbradar and @dezgeg to be potential reviewers. |
|
I guess it was updated in master in the meanwhile; I picked your change about Is the current |
|
That looks great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also marked murmur_git as unbroken, as long as iceSupport is disabled.
Motivation for this change
Murmur_git was marked as broken, which is only true when built against an optional dependency. See #24383.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)