Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: remove broken tests #24609

Merged
merged 1 commit into from Apr 8, 2017
Merged

terraform: remove broken tests #24609

merged 1 commit into from Apr 8, 2017

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Apr 3, 2017 •
edited

Motivation for this change

Followup after #24505

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@zimbatm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peterhoeg, @kamilchm and @brainrape to be potential reviewers.

@copumpkin
Copy link
Member

Any idea why they're broken? Does upstream know?

@bdimcheff
Copy link
Contributor

This worked for me fwiw

@zimbatm
Copy link
Member Author

zimbatm commented Apr 4, 2017 via email

@aristidb aristidb merged commit 17fc70a into NixOS:master Apr 8, 2017
@zimbatm zimbatm deleted the terraform-fix branch April 10, 2017 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zimbatm @mention-bot @copumpkin @bdimcheff @aristidb