nodePackages_4_x: remove in favor of nodePackages_6_x #25006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @svanderburg and @rvl to be potential reviewers. |
|
There are still a couple of packages that require Node.js 4.x. Most
notably, there is the titanium CLI that only works with 4.x. Moreover, it
may also be desirable to use grunt in combination with Node.js/npm 2.x for
projects that are still using the old Node.js infrastructure.
Perhaps splitting the two JSON files providing a minimal 4.x package set
would be better than generating two expressions for the same packages, but
removing it completely will not work.
…On Tue, Apr 18, 2017 at 8:29 PM, Jörg Thalheim ***@***.***> wrote:
@Mic92 <https://github.com/Mic92> requested your review on:
NixOS/nixpkgs#25006 <#25006>
nodePackages_4_x: remove in favor of nodePackages_6_x.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25006 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABGY92i5tDfdjB1Dq_DErvc8kde733Hvks5rxR0RgaJpZM4NA2nc>
.
|
|
replaced by #25528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently we maintain too large package sets (~40.000 LoCs) for nodejs v4 and nodejs v6 with identical input.
nodePackages_6_x is currently the active alias to nodePackages. Do we really need both?
If there packages, which would justify a certain node version, could we not just maintain two
node-packages.jsonfor each version?Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)