Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomacs: 3.4 -> 3.6.1 #24589

Closed
wants to merge 1 commit into from
Closed

nomacs: 3.4 -> 3.6.1 #24589

wants to merge 1 commit into from

Conversation

lprndn
Copy link
Contributor

@lprndn lprndn commented Apr 3, 2017

Motivation for this change

After testing, building nomacs no longer works.
Fixed version number in sourceRoot conflicts with hardcoded folder name.
Choosed to swith to fetchurl and github releases instead of fetching from repository to avoid future problems.
Updated version in the meantime.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lprndn
Copy link
Contributor Author

lprndn commented Apr 3, 2017

@ahmedtd As maintainer of the package, hope modifications are ok for you.
I've been trying to build nomacs not long ago and never managed to deal with appdatas errors so thank you.

@joachifm
Copy link
Contributor

joachifm commented Apr 3, 2017

Re fetchurl change, you're still using auto-generated tarballs, so it's equivalent to fetchFromGitHub.

@lprndn
Copy link
Contributor Author

lprndn commented Apr 3, 2017

Oh my bad! Thanks for clarification.
Anyway after investigation, when using fetchFromGithub, source root should apparently be nomacs-${version}-src. Depending of what is preferred between fetchurl and fetchFromGithub, I can adapt my commit so we can still update to 3.6.1.

@joachifm
Copy link
Contributor

joachifm commented Apr 3, 2017

setSourceRoot lets you set the soure root dynamically, if need be.

I think we typically want to use fetchFromGitHub because it's slightly more flexible (and robust to changes in the compression of generated archives, but that's less of a concern these days, at least with gzip compressed archives).

@ahmedtd
Copy link
Contributor

ahmedtd commented Apr 3, 2017

@lprndn No problem. Sorry for the delay in responding.

My original merge request for 3.4 was based on fetchUrl, but was modified to use fetchFromGithub in the review process. So we should probably stick with fetchFromGithub.

@Mic92 Mic92 closed this in 75319eb Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lprndn @joachifm @ahmedtd