nomacs: init at 3.4 #24580
Merged
nomacs: init at 3.4 #24580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndowens
suggested changes
Apr 2, 2017
|
|
||
| patches = [./fix-appdata-install.patch]; | ||
|
|
||
| buildInputs = [cmake |
There was a problem hiding this comment.
Cmake pkgconfig and makeWrapper belong in nativeBuildInputs
Mic92
reviewed
Apr 3, 2017
| stdenv.mkDerivation rec { | ||
| version = "3.4"; | ||
| src = fetchurl { | ||
| url = "https://github.com/nomacs/nomacs/archive/${version}.tar.gz"; |
There was a problem hiding this comment.
We prefer fetchFromGitHub usually here.
Mic92
reviewed
Apr 3, 2017
| src = fetchurl { | ||
| url = "https://github.com/nomacs/nomacs/archive/${version}.tar.gz"; | ||
| sha256 = "552eda88aedea48831ce354095e3aad47892b4b5029f424171bedb68271c2a2f"; | ||
| sha512 = "67a1b57971dc373d5a3be75b7deaff6702893252568eef135903754b2465416a58b40f18f55cf2994c8c3853ae96b82506c1caf26b0e645c20179a9cd81c0d36"; |
There was a problem hiding this comment.
There is no need for having both checksum. Only one checksum is evaluated at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add nomacs-3.4, a Qt-based image viewer.
Things done
nix-shell -p nox --run "nox-review wip"./result/bin/)