New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add services for Bitcoin, Dash, Parity and Monero #24576
Conversation
@koenigmaximilian, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @joachifm and @offlinehacker to be potential reviewers. |
default = defaultUser; | ||
description = userDescription; | ||
type = types.str; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since static user/group names are allocated, it is not really configurable. I would just drop these two options here and in every other service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really get what you mean. You can set user with services.bitcoind.user or services.dashd.user
Static is only the default value.
description = opts.user.description; | ||
home = cfg.dataDir; | ||
createHome = true; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really requires a home in "/home"? Usually system user a created in /var/lib/. This directory can be created on service start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sets cfg.dataDir as home directory (not /home)
parity/ethash requires a valid home dir: https://github.com/paritytech/parity/blob/8404edb656693270ec1cd3956d204f625d28ec7c/ethash/src/compute.rs#L109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the reason I chose the data directory and not a path in /var/lib is that I'm used to have the data dir on an encrypted partition and don't want information to be leaked by ethash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No surprises here.
This PR still seems relevant. Is there motivation to make this up-to-date with master? |
@MDeltaX please rebase or close the PR |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Please feel free to reopen or start a new PR if there is any interest. |
Requires #24396