@jbgi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @edwtjo and @peterhoeg to be potential reviewers.

cc @titanous

Is there a reason why you didn't pick the forked libdvdcss as well? Also, travis seems to fail building kodi due to some linking error. Can you double check? Thanks!

I cannot see why travis is failing. My machine is on 17.03, could that be the reason why I cannot reproduce the failure of nix-build -A kodiPlain -A kodi -A kodiPlugins.pvr-hts?

As for libdvdcss I did not use kodi fork, as their commits do not look like to be kodi-specific but just fixes/improvement that should be send to the upstream project. The upstream project did not want kodi "fixes" and is still actively maintained, with many commits ahead of kodi fork, potentially fixing same/more issues than the fork.

Heh, that's what happens with master on my machine:

[ RUN      ] TestJobManager.AddJob
/nix/store/fibk8jc2iwswn1q1d7aw98pcw2l3lzjf-bash-4.4-p12/bin/bash: line 1: 31312 Segmentation fault      /tmp/nix-build-kodi-17.1.drv-0/xbmc-17.1-Krypton/$check_program
make: *** [Makefile:618: check] Error 139
builder for ‘/nix/store/wj1a5rahrn40d3s4bgi3s9ljhx0g4zx3-kodi-17.1.drv’ failed with exit code 2
error: build of ‘/nix/store/wj1a5rahrn40d3s4bgi3s9ljhx0g4zx3-kodi-17.1.drv’ failed
The invocation of "nix-build -A kodiPlugins.pvr-hts -A kodiPlain -A kodi /home/page/dev/nixpkgs" failed

So it built kodi but segfaults in a test. Can you test on master and see what do you get?
Also, would be nice if you can add a small comment making it clear that we're picking the forks cause otherwise dvd playback does not work.

The crash seems to be no longer an issue.

@Mic92 can you also backport the fix to 17.03?

Done, thanks