New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gammu: 1.33.0 -> 1.38.2 #24582
gammu: 1.33.0 -> 1.38.2 #24582
Conversation
@jerith666, thanks for your PR! By analyzing the history of the files in this pull request, we identified @coroa, @zohl and @phanimahesh to be potential reviewers. |
}; | ||
|
||
patches = [ ./bashcomp-dir.patch ]; | ||
patches = [ ./bashcomp-dir.patch ./systemd.patch ]; | ||
|
||
buildInputs = [ python pkgconfig cmake bluez libusb1 curl gettext sqlite libiconv ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pkgconfig cmake goes in nativeBuildInputs
@ndowens done in c33c72b |
Thanks
…Sent from my iphone
On Apr 4, 2017, 7:36 PM -0500, Matt McHenry ***@***.***>, wrote:
@ndowens (https://github.com/ndowens) done in c33c72b (c33c72b)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#24582 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL7yyo2iCAXCahxnNPlhnkOBBi2H9jks5rsuHvgaJpZM4MxChs).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the latest release is 1.38.2 now. Why not update to that version directly?
src = fetchFromGitHub { | ||
owner = "gammu"; | ||
repo = "gammu"; | ||
rev = "49b0b19f59c740817a9582303b8814d8488dc725"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be better (fetch by tag name):
rev = version;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup I agree, I tend to use version or v${version} if possible
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)