Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yoda: 1.6.5 -> 1.6.6, provide version with ROOT #24583

Merged
merged 4 commits into from May 1, 2017
Merged

yoda: 1.6.5 -> 1.6.6, provide version with ROOT #24583

merged 4 commits into from May 1, 2017

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 3, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@veprbl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat to be a potential reviewer.

Mic92
Mic92 reviewed Apr 3, 2017
View reviewed changes
pkgs/development/libraries/physics/yoda/default.nix Outdated
};

pythonPath = []; # python wrapper support

buildInputs = with python2Packages; [ python numpy matplotlib makeWrapper ];
buildInputs = with python2Packages; [ python numpy matplotlib root makeWrapper ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the disadvantage of having this enabled by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROOT adds 433 mb to closure and the only practical reason to enable it is to have root2yoda and yoda2root utilities. The reverse dependencies of YODA don't care about those. So yoda-with-root is for using interactively when user need those extra conversion utilities (most often you don't need those, actually).

@rasendubi
Copy link
Member 

trying https://yoda.hepforge.org/hg/yoda/rev/3dbc8927e715?style=raw
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1017    0  1017    0     0   2128      0 --:--:-- --:--:-- --:--:--  3852
output path ‘/nix/store/cy0yrq6gr61j108cpzsmbjrinrq2fhzc-3dbc8927e715?style=raw’ has sha256 hash ‘02rm34z9lbab66p7gpij1
2qwdph5fddpksg80qz0m537wjwy2ddy’ when ‘0rjgyfxwl5pps2n3fhjnyiwjn20fmwxvpbvavp0jnh8j8pjclrnj’ was expected
cannot build derivation ‘/nix/store/95j49nnzpf147dpbyr3cfcw64m6kd69w-yoda-1.6.6.drv’: 1 dependencies couldn't be built

@veprbl
Copy link
Member Author

veprbl commented Apr 6, 2017

I guess this is one of those instances when nix-prefetch-url returns something completely different from what nix-build sees. I fixed the hashes. @rasendubi Sorry and thank you!

@rasendubi
Copy link
Member

fetchpatch does additional processing of the downloaded patches, so the hash is usually different from fetchurl.

@veprbl
Copy link
Member Author

veprbl commented Apr 6, 2017

I did not realize that. Thanks. Also in my tests nix-prefetch-url -A doesn't work with fetchpatch either.

@7c6f434c 7c6f434c merged commit 9c770f6 into NixOS:master May 1, 2017
@vcunat
Copy link
Member

vcunat commented May 1, 2017

I believe nix-prefetch-url -A would work fine with fetchpatch, but it won't work with lists – and you typically use it in the patches list.

@veprbl
Copy link
Member Author

veprbl commented May 1, 2017

@vcunat In my tests I was creating a separate attribute to overcome the list problem. I believe that still didn't get a correct hash even after that.

@veprbl veprbl deleted the yoda166 branch December 1, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@veprbl @mention-bot @rasendubi @vcunat @Mic92 @joachifm @7c6f434c