New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simgrid: 3.11.1 -> 3.15 #24915
simgrid: 3.11.1 -> 3.15 #24915
Conversation
@Sophia-Gold, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c, @bjornfor and @Fuuzetsu to be potential reviewers. |
Per CONTRIBUTING.md commit messages should be formatted: |
I think you changed the PR title instead of the commit message |
Also, in general such updates should be submitted against |
Apologies. I neglected to create a new branch after checking out the master and therefore decided to make this commit through the GUI, which explains some of the oddness. I'm not sure how to amend the message now, if that's even preferable. |
Cherry-picked into |
Thank you. |
Command-line |
Thanks for the update. |
(cherry picked from commit 9fc61d0)
For reference, sandboxed builds got broken by this, but it should be OK now. |
That's odd. I built it on NixOS with a local path and got none of these errors. Glad to hear they're resolved, though. |
Well, look at the fix — you probably have a global |
Got it. Next time I'll enable sandboxing when testing a new package. |
Most contributors use sandboxing all the time, I think. There's just a split-second penalty per derivation, so that's totally worth it for me. |
Motivation for this change
Version 3.11.1 was no longer compatible with the SimGrid documentation.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)