intel-gpu-tools: 1.17 -> 1.18 #24920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.17 fails to build with the current libdrm because of a changed struct (`drm_event_vblank`). I had to patch `tools/Makefile.am` to use `GLIB_CFLAGS`; otherwise, the build failed to find `glib.h`.
|
@mbrock, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pSub and @wkennington to be potential reviewers. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Version 1.17 fails to build with the current libdrm
because of a changed struct (
drm_event_vblank).I had to patch
tools/Makefile.amto useGLIB_CFLAGS;otherwise, the build failed to find
glib.h.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)