Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup: init at 1.2.0 #24927

Merged
merged 1 commit into from Apr 17, 2017
Merged

rustup: init at 1.2.0 #24927

merged 1 commit into from Apr 17, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 15, 2017

Motivation for this change

use pre-compiled cross compiler + access to nightlies

depends on #24926

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wizeman, @madjar and @dvc94ch to be potential reviewers.

@matthiasbeyer
Copy link
Contributor

I would not include this package in nixpkgs, as we have the mozilla overlay which gives us the very same functionality, but on a nix-level.

I'd opt for rejecting this PR.

@Mic92
Copy link
Member Author

Mic92 commented Apr 15, 2017

Does this overlay provides support cross compiler for targets like x86_64-rumprun-netbsd? I also need components as used in https://github.com/japaric/xargo

@matthiasbeyer
Copy link
Contributor

I honestly don't know, sorry.

@Mic92
Copy link
Member Author

Mic92 commented Apr 15, 2017

Rustup now works with unmodified toolchains on Nixos! No more patchelf.

@Mic92 Mic92 merged commit c7ac0f3 into NixOS:master Apr 17, 2017
@Mic92
Copy link
Member Author

Mic92 commented Apr 17, 2017

I merge this anyway despite the existence of the overlay, for the following reason:

  • the overlay seems to address only native compiler targets
  • there are still some performance issues with the self-written toml parser: https://www.mail-archive.com/nix-dev@lists.science.uu.nl/msg36074.html
  • rustup is somewhat a defacto standard within the rust community. For people like me who works with upstream projects, it is helpful to be able to use the same scripts and commands to reproduce a test environment like travis ci.

@Mic92 Mic92 deleted the rustup branch April 17, 2017 15:10
@nbp
Copy link
Member

nbp commented Apr 17, 2017

Does this overlay provides support cross compiler for targets [...]?

Not yet, but we can install extensions for the same target, and installing extension for cross-compiling should be doable by changing a few Nix expressions, as soon as someone is interested in contributing these bits back.

@retrry
Copy link
Contributor

retrry commented Apr 26, 2017

How are you using rustup in NixOS setting? Currently I'm trying to use it in nix-shell and I get error, when trying to build my project.

error[E0463]: can't find crate for std

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants