dhcpcd service: clear exit code of exitHook #24909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ck3d, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @wkennington and @peti to be potential reviewers. |
Mic92
reviewed
Apr 15, 2017
|
|
||
| # exit code of last command is propagated, so we have to clear it | ||
| true | ||
| ${config.systemd.package}/bin/systemctl try-reload-or-restart ntpd.service openntpd.service || true |
There was a problem hiding this comment.
We have now systemd-timesyncd in nixos as default. Does it require a reload too, or is it smart enough to resolving endpoints on its own?
There was a problem hiding this comment.
I like your solution.
We use systemd-timesyncd without issues. A restart is not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The exit code of the dhcpcd exitHook is not zero if openntp is not installed.
This exit code needs to be reset to avoid following error log:
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)