kubernetes: fix interpolation error and move services to own target #24921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @fpletz and @nckx to be potential reviewers. |
|
Thanks! |
|
Why did you need toString? imap nethod should always return numbers. |
Because |
|
ah yes, of course, tnx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The first commit is a straight up fix for a bug where enabling the cni network
plugin will make evaluation fail.
The second part shifts the kubernetes services into their own slice and makes
the launch happen via a dedicated kubernetes target.
The reason for moving into its own slice and target is that it makes starting
and stopping far easier plus it allows for resource allocations.
Cc: @offlinehacker
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)