Improve latex formula renderer (bugfixes, refactoring, adding support for other TeX engines) #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
reviewed
Apr 15, 2017
| @@ -89,6 +89,7 @@ def __init__(self): | |||
| super(LatexImageFormulaRenderer, self).__init__() | |||
| self.__formula_scale = 1.25 | |||
There was a problem hiding this comment.
PS. I really dislike those double underscores.
There was a problem hiding this comment.
Because they look ugly, because they don't really give privacy, or because of something else?
There was a problem hiding this comment.
That, and they may mess up in some situations where you never expect it. This probably won’t happen in a Nikola plugin that doesn’t get inherited though.
| 'programs': ['lualatex'], | ||
| 'head': R"""\RequirePackage{luatex85} | ||
| \documentclass{standalone} | ||
| \usepackage[T1]{fontenc} |
There was a problem hiding this comment.
\usepackage{fontspec} would be a better choice for LuaTeX.
|
(Merge at will, since plugins do not require reviews.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version should be backwards compatible to old instances of the latex compiler plugin (and other plugins).
Also includes a fix for the latex compiler plugin to allow setting the TeX engine for formula rendering.