Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-edit: init at 0.1.6 #24932

Merged
merged 1 commit into from Apr 16, 2017
Merged

cargo-edit: init at 0.1.6 #24932

merged 1 commit into from Apr 16, 2017

Conversation

jb55
Copy link
Contributor

@jb55 jb55 commented Apr 15, 2017

Motivation for this change

cargo-edit is a tool that adds cargo add which is similar to npm install --save

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

The darwin build fails, is that platform supported?

@Mic92
Copy link
Member

Mic92 commented Apr 16, 2017

Looks like it was compiling rust:

The job exceeded the maximum time limit for jobs, and has been terminated.

@joachifm
Copy link
Contributor

Ah, so this is related to the Hydra-not-building rust thing. Then I think we can safely ignore it :)

@Mic92 Mic92 merged commit 769de56 into NixOS:master Apr 16, 2017
@Mic92
Copy link
Member

Mic92 commented Apr 17, 2017

It seems to require curl on darwin: https://hydra.nixos.org/build/51727976/nixlog/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants