pass: fix clipboard functionality for darwin #24797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the patch that was removed that allows pass's clip() function to work with single binary coreutils. This version of the patch is also applied to darwin.sh, so this should fix the clipboard functionality in darwin as well.
|
@nixy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @fpletz and @the-kenny to be potential reviewers. |
|
Looks good, but is there a way we can get this patch moved upstream? Single-binary coreutils should be common enough for them to support. |
|
ping @zx2c4 |
|
Probably also related to https://git.zx2c4.com/password-store/commit/?id=b08781e2a6e183986eb1c24f51cdeff879b7a6af |
LnL7
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the patch that was removed that allows pass's clip() function to
work with single binary coreutils. This version of the patch is also
applied to darwin.sh, so this should fix the clipboard functionality in
darwin as well.
Motivation for this change
Currently
pass -cdoesn't work correctly on Darwin. The patch that made it work on Linux systems was removed in the update to 1.7, potentially because this issue had been resolved on Linux. This still affects macOS users who need this patch though. Some of this was discussed in #17296 and #17267Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)