New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
csscompressor: init at 0.9.4 #24946
csscompressor: init at 0.9.4 #24946
Conversation
pkgs/top-level/python-packages.nix
Outdated
@@ -2524,6 +2524,23 @@ in { | |||
doCheck = false; # lazy packager | |||
}; | |||
|
|||
csscompressor = buildPythonPackage rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this expression into a separate file in ./pkgs/development/python-modules
license = stdenv.lib.licenses.bsd3; | ||
maintainers = [stdenv.lib.maintainers.ahmedtd]; | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a syntax error
pkgs/top-level/python-packages.nix
Outdated
@@ -2524,6 +2524,8 @@ in { | |||
doCheck = false; # lazy packager | |||
}; | |||
|
|||
csscompressor = callPackage ../development/python-modules/csscompressor.nix; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect this should look more like callPackage foo { }
, as it is this is a partially applied function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's why nox-review said there was nothing to check --- I had assumed it was just because the actual derivation didn't change.
LGTM. Thank you |
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"