Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csscompressor: init at 0.9.4 #24946

Merged
merged 1 commit into from Apr 17, 2017
Merged

csscompressor: init at 0.9.4 #24946

merged 1 commit into from Apr 17, 2017

Conversation

ahmedtd
Copy link
Contributor

@ahmedtd ahmedtd commented Apr 16, 2017

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested ability to import and use package in python interpreter
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ahmedtd, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@@ -2524,6 +2524,23 @@ in {
doCheck = false; # lazy packager
};

csscompressor = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this expression into a separate file in ./pkgs/development/python-modules

license = stdenv.lib.licenses.bsd3;
maintainers = [stdenv.lib.maintainers.ahmedtd];
};
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a syntax error

@@ -2524,6 +2524,8 @@ in {
doCheck = false; # lazy packager
};

csscompressor = callPackage ../development/python-modules/csscompressor.nix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this should look more like callPackage foo { }, as it is this is a partially applied function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's why nox-review said there was nothing to check --- I had assumed it was just because the actual derivation didn't change.

@joachifm joachifm merged commit f029fc8 into NixOS:master Apr 17, 2017
@joachifm
Copy link
Contributor

LGTM. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants