desmume: fix mesa+osmesa #24949
Merged
desmume: fix mesa+osmesa #24949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It builds fine, but some better testing should be done before merging.
|
@vcunat, thanks for your PR! By analyzing the history of the files in this pull request, we identified @AndersonTorres and @zimbatm to be potential reviewers. |
|
Many thanks, @vcunat ! I will test it now. Edit: it is running fine here. The only problem is when I run it on KDE - it blocks in the screen to set the joystick controls. Strangely, it runs fine on XFCE! |
|
So this PR makes it worse on KDE? (Perhaps it would be better not to merge, if the improvement isn't as significant on non-KDE.) |
|
No, it doesn't make things worse. The same bug(?) affects the current building now, it doesn't change a thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It builds fine, but some better testing should be done before merging. @AndersonTorres: can you verify it works OK?
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
./result/bin/)