cppcheck: update and support rule-file. #24937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
layus
commented
Apr 15, 2017
layus
commented
- Tested on NixOS.
joachifm
reviewed
Apr 15, 2017
| }; | ||
|
|
||
| nativeBuildInputs = [ libxslt docbook_xsl docbook_xml_dtd_45 ]; | ||
| nativeBuildInputs = [ libxslt docbook_xsl docbook_xml_dtd_45 pcre ]; |
There was a problem hiding this comment.
Does this mean cppcheck doesn't use pcre at runtime for this?
There was a problem hiding this comment.
Well, no :-). Good catch. That being said, there is no real difference in practice :-D.
|
@joachifm Updated according to comment. |
|
looks like a transient error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.