Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dale: init at 20170416 #24941

Merged
merged 1 commit into from Apr 17, 2017
Merged

dale: init at 20170416 #24941

merged 1 commit into from Apr 17, 2017

Conversation

amiloradovsky
Copy link

Lisp-flavoured C. Dale is a system (no GC) programming language
that uses S-expressions for syntax and supports syntactic macros.

Motivation for this change

To play with an interesting experimental, but having the potential
to be quite useful, programming language.

https://github.com/tomhrr/dale

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Apr 16, 2017
View reviewed changes
pkgs/development/compilers/dale/default.nix Outdated

postBuild = if with_tests then "make tests" else "";

with_tests = false; # 'cause failed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already doCheck and checkPhase for this purpose.

Mic92
Mic92 reviewed Apr 16, 2017
View reviewed changes
pkgs/development/compilers/dale/default.nix Outdated
src = fetchFromGitHub {
owner = "tomhrr";
repo = "dale";
rev = "9340841001425a4c0fc2dcccf77b356eccee6afb";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version does not match revision chosen here.

@amiloradovsky amiloradovsky changed the title dale: init at 0.1 dale: init at 20170416 Apr 16, 2017
joachifm
joachifm reviewed Apr 16, 2017
View reviewed changes
pkgs/development/compilers/dale/default.nix Outdated
buildInputs = [ cmake libffi llvm_35 ] ++
stdenv.lib.optional doCheck perl;

prePatch = ''substituteInPlace ./t/src/include-test.dt --replace include-test-2.dt \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please format like this

let # ignore this
foo = ''
  lorem ipsum
''

joachifm
joachifm reviewed Apr 16, 2017
View reviewed changes
pkgs/development/compilers/dale/default.nix Outdated

meta = with stdenv.lib; {
description = "Lisp-flavoured C";
longDescription = "Dale is a system (no GC) programming language that uses S-expressions for syntax and supports syntactic macros";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please use an indented string for the longDescription.

dale: init at 20170416
da9a147 
Lisp-flavoured C. Dale is a system (no GC) programming language
that uses S-expressions for syntax and supports syntactic macros.
@amiloradovsky
Copy link
Author

amiloradovsky commented Apr 17, 2017 •
edited

Regarding the Darwin port, here is an excerpt from the CI log, in case someone can make any sense out of it:

[ 73%] Linking CXX executable dalec
clang-4.0: warning: argument unused during compilation: '-ansi' [-Wunused-command-line-argument]
Undefined symbols for architecture x86_64:
  "_ffi_call", referenced from:
      llvm::Interpreter::callExternalFunction(llvm::Function*, std::__1::vector<llvm::GenericValue, std::__1::allocator<llvm::GenericValue> > const&) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_prep_cif", referenced from:
      llvm::Interpreter::callExternalFunction(llvm::Function*, std::__1::vector<llvm::GenericValue, std::__1::allocator<llvm::GenericValue> > const&) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_double", referenced from:
      llvm::Interpreter::callExternalFunction(llvm::Function*, std::__1::vector<llvm::GenericValue, std::__1::allocator<llvm::GenericValue> > const&) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_float", referenced from:
      llvm::Interpreter::callExternalFunction(llvm::Function*, std::__1::vector<llvm::GenericValue, std::__1::allocator<llvm::GenericValue> > const&) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
      l_switch.table in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_pointer", referenced from:
      llvm::Interpreter::callExternalFunction(llvm::Function*, std::__1::vector<llvm::GenericValue, std::__1::allocator<llvm::GenericValue> > const&) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_sint16", referenced from:
      l_switch.table in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_sint32", referenced from:
      l_switch.table in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_sint64", referenced from:
      l_switch.table in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_sint8", referenced from:
      l_switch.table in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
  "_ffi_type_void", referenced from:
      llvm::Interpreter::callExternalFunction(llvm::Function*, std::__1::vector<llvm::GenericValue, std::__1::allocator<llvm::GenericValue> > const&) in libLLVMInterpreter.a(ExternalFunctions.cpp.o)
ld: symbol(s) not found for architecture x86_64
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [CMakeFiles/dalec.dir/build.make:2955: dalec] Error 1
make[1]: *** [CMakeFiles/Makefile2:1690: CMakeFiles/dalec.dir/all] Error 2
make: *** [Makefile:128: all] Error 2
builder for ‘/nix/store/bbyx0hy95shg0ly6wpv9n1549l8nni3z-dale-0.1.drv’ failed with exit code 2

On the other hand, it may be due to a more "global" issue. Supposedly with LLVM.

@Mic92 Mic92 merged commit e8f2046 into NixOS:master Apr 17, 2017
@amiloradovsky amiloradovsky deleted the dale branch April 18, 2017 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amiloradovsky @joachifm @Mic92