Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: use upstream's recommendation for enabling interfaces #24948

Merged
merged 1 commit into from Apr 16, 2017

Conversation

peterhoeg
Copy link
Member

Motivation for this change

bluez no longer recommends spawning "hciconfig up" from a udev rule as the main bluez daemon now supports automatically enabling power for all devices.

Reference: http://www.bluez.org/release-of-bluez-5-35/

I'm running it here on my notoriously bluetooth-flaky yoga 2 pro and it works great.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

bluez no longer recommends spawning "hciconfig <device> up" from a udev rule as
the main bluez daemon now supports automatically enabling power for all devices.

Reference: http://www.bluez.org/release-of-bluez-5-35/
@mention-bot
Copy link

@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @heydojo and @rnhmjoj to be potential reviewers.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 16, 2017

👍 The hciconfig method has been randomly failing for quite some time for me.

@Mic92 Mic92 merged commit 16f5bc0 into NixOS:master Apr 16, 2017
@peterhoeg peterhoeg deleted the m/bluetooth branch April 16, 2017 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants