Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

astroid: 0.7 -> 0.8 #24593

Merged
merged 1 commit into from Apr 8, 2017
Merged

astroid: 0.7 -> 0.8 #24593

merged 1 commit into from Apr 8, 2017

Conversation

bdimcheff
Copy link
Contributor

@bdimcheff bdimcheff commented Apr 3, 2017 •
edited

Motivation for this change

Upgraded astroid to 0.8 and uses the upstream changes to properly
propagate environment without a patch. Note that this still uses an
unsupported version of webkitgtk and thus will fail to build, but if
allow webkitgtk to install, astroid will run.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bdimcheff
astroid: 0.7 -> 0.8
aac3f9a 
Upgraded astroid to 0.8 and uses the upstream changes to properly
propagate environment without a patch.  Note that this still uses an
unsupported version of webkitgtk and thus will fail to build, but if
allow webkitgtk to install, astroid will run.
@mention-bot
Copy link

@bdimcheff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz to be a potential reviewer.

@bdimcheff
Copy link
Contributor Author

@SuprDewd I finally got around to this ;)

@rasendubi
Copy link
Member

Well, that's strange:

=== Reviewing PR 24593 : astroid: 0.7 -> 0.8
==> Creating nixpkgs repo in /home/travis/.nox/nixpkgs
==> We're in a git repo, trying to fetch it
==> Fetching base (master)
==> Fetching PR
==> Fetching extra history for merging
==> Merging PR into base
Removing pkgs/applications/networking/mailreaders/astroid/propagate-environment.patch
Nothing changed

@aristidb aristidb merged commit 9f148e9 into NixOS:master Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bdimcheff @mention-bot @rasendubi @aristidb