Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pharo-vm: Disable "pic" hardening #24595

Merged
merged 1 commit into from Apr 4, 2017
Merged

Conversation

lukego
Copy link
Contributor

@lukego lukego commented Apr 3, 2017

Compiling the Pharo VM with "pic" hardening causes segmentation faults on startup of pharo-launcher.

Motivation for this change

Resolves #24541.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Compiling the Pharo VM with "pic" hardening causes segmentation faults
on startup of pharo-launcher.

Resolves NixOS#24541.
@mention-bot
Copy link

@lukego, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DamienCassou, @fpletz and @globin to be potential reviewers.

@lukego lukego mentioned this pull request Apr 3, 2017
@fpletz fpletz added this to the 17.03 milestone Apr 3, 2017
@lukego
Copy link
Contributor Author

lukego commented Apr 4, 2017

This seems to be only a partial fix. On the one hand it permits me to run pharo-launcher but on the other hand there is a different error when trying to run the latest Pharo image by downloading it and running pharo-spur-vm-x Pharo-50771.image.

nixpkgs is bundling two Pharo VMs and it could be that the traditional one is working while the new Spur VM is still broken. I'll dig a little more.

@lukego
Copy link
Contributor Author

lukego commented Apr 4, 2017

@domenkozar I would recommend merging this PR in order to fix the current Pharo version and make the test case merged in #24597 pass. This will put everything into a basically okay state: default Pharo VM in NixOS will work but it will still be a bit old.

I am working with Pharo upstream to refresh things more completely. The problem is that not all of the necessary components have official releases at the moment and everybody is running versions served up from the Pharo CI server which is not doing this in a reproducible/nix-friendly way.

@domenkozar
Copy link
Member

@lukego that makes sense, thanks!

@domenkozar domenkozar merged commit f3dbaa7 into NixOS:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants