Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift: remove i686-linux from platforms, limit to x86-64-linux #24441

Merged
merged 1 commit into from Mar 30, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 29, 2017

Don't know that other platforms will fail but it seems likely
since we're using build profile intended for 64bit Ubuntu.

Motivation for this change

Hydra failure on 32bit, investigation suggests (Swift doesn't support 32bit Linux)[https://bugs.swift.org/browse/SR-124] although it might be possible with some effort.

Hopefully Darwin will be supported soon, but doesn't work yet (if nothing else the build forces the linux build profile).

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Don't know that other platforms will fail but it seems likely
since we're using build profile intended for 64bit Ubuntu.
@joachifm joachifm merged commit 20bf944 into NixOS:master Mar 30, 2017
@dtzWill dtzWill deleted the fix/swift-64bit-only branch March 30, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants