Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suitesparse: add CUDA support #24443

Merged
merged 1 commit into from Mar 29, 2017
Merged

suitesparse: add CUDA support #24443

merged 1 commit into from Mar 29, 2017

Conversation

mdaiter
Copy link
Contributor

@mdaiter mdaiter commented Mar 29, 2017 •
edited

Motivation for this change

Adding CUDA support to SuiteSparse can accelerate computational times for users with NVidia GPUs.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@mdaiter, thanks for your PR! By analyzing the history of the files in this pull request, we identified @acowley, @globin and @dezgeg to be potential reviewers.

@mdaiter
Copy link
Contributor Author

mdaiter commented Mar 29, 2017

cc @ttuegel (maintainer of this package). You should be included in this too, no?

@acowley
Copy link
Contributor

acowley commented Mar 29, 2017

I can't test that the cuda parts work, but the diff looks good.

@ttuegel ttuegel merged commit 079ee64 into NixOS:master Mar 29, 2017
@ttuegel
Copy link
Member

ttuegel commented Mar 29, 2017

You should be included in this too, no?

Probably. 😉

I can't test CUDA, but all the changes are guarded behind enableCuda, so I don't imagine this could hurt.

@mdaiter mdaiter deleted the sparsesuiteCUDA branch March 29, 2017 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdaiter @mention-bot @acowley @ttuegel