cups-toshiba-estudio: init at 7.51 #24676
Conversation
| # TOSHIBA e-STUDIO6550C | ||
| # TOSHIBA e-STUDIO6560C | ||
| # TOSHIBA e-STUDIO6570C | ||
| # TOSHIBA e-STUDIO7506AC |
There was a problem hiding this comment.
It might make sense to put that in the meta.longDescription to make it searchable as a user.
| "installPhase" ]; | ||
|
|
||
| preInstall = '' | ||
| ls |
There was a problem hiding this comment.
Ooops, didn't see this one
| preInstall = '' | ||
| ls | ||
| patchShebangs lib/ | ||
| head lib/cups/filter/est6550_Authentication |
| head lib/cups/filter/est6550_Authentication | ||
|
|
||
| gunzip share/cups/model/Toshiba/TOSHIBA_ColorMFP_CUPS.gz | ||
| sed -i "s+/usr+$out+" share/cups/model/Toshiba/TOSHIBA_ColorMFP_CUPS |
There was a problem hiding this comment.
is there only one /usr to patch?
There was a problem hiding this comment.
Yes, any thought on how to do it better?
| "preInstall" | ||
| "installPhase" ]; | ||
|
|
||
| preInstall = '' |
There was a problem hiding this comment.
can you call this the configurePhase or patchPhase? pre-phases are supposed to be called from the phase itself
There was a problem hiding this comment.
Let's go for patchPhase
| description = "Printer only driver for the Toshiba e-STUDIO class of printers"; | ||
| homepage = https://www.toshiba-business.com.au/support/drivers; | ||
| license = stdenv.lib.licenses.unfree; | ||
| maintainers = with stdenv.lib.maintainers; [ jpotier ]; |
There was a problem hiding this comment.
adding with stdenv.lib; on the whole meta block removes a bit of duplication, not required though
There was a problem hiding this comment.
Looks cleaner, will do
|
About testing: I've first built it as an independant package and I manually selected the PPD when installing the printer with CUPS. Then, I forked and cloned nixpkgs locally and added the package (this commit). I added the printer driver in the |
Motivation for this change
There was no driver for the toshiba-estudio series of printers. This is a generic driver that supports many
printers (see comment in the
default.nix).Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"