Skip to content

Commit

Permalink
sddm: Fix test.
Browse files Browse the repository at this point in the history 
For whatever reason, the OCR code is not detecting ALICE but is BOB.

OCR output from login screen (blank lines omitted):

> Session none + icewm
> 08:41 <
> Thursday, April 6, 2017
> BOB FOOBAR
> Select your user and enter password
  • Loading branch information
@shlevy
shlevy committed Apr 6, 2017
1 parent e105ba6 commit 0a6a063
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nixos/tests/sddm.nix
View file
Expand Up @@ -24,7 +24,7 @@ let
user = nodes.machine.config.users.extraUsers.alice;
in ''
startAll;
$machine->waitForText(qr/ALICE/);
$machine->waitForText(qr/BOB/);
$machine->screenshot("sddm");
$machine->sendChars("${user.password}\n");
$machine->waitForFile("/home/alice/.Xauthority");
Expand Down

9 comments on commit 0a6a063

@shlevy
Copy link
Member Author

@shlevy shlevy commented on 0a6a063 Apr 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aszlig any idea why this might have broken recently? The screenshot clearly has ALICE as well as BOB

@shlevy
Copy link
Member Author

@shlevy shlevy commented on 0a6a063 Apr 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ocrin

@aszlig
Copy link
Member

@aszlig aszlig commented on 0a6a063 Apr 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shlevy: No idea, maybe a bisect gives some clue about it?

@shlevy
Copy link
Member Author

@shlevy shlevy commented on 0a6a063 Apr 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aszlig Fiiiine

@shlevy
Copy link
Member Author

@shlevy shlevy commented on 0a6a063 Apr 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I can't get the test to pass on old commits where it succeeded on hydra 😮

@Mic92
Copy link
Member

@Mic92 Mic92 commented on 0a6a063 Apr 7, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks related to my fix: #23264

@shlevy
Copy link
Member Author

@shlevy shlevy commented on 0a6a063 Apr 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not really, this is a fix to the testing infrastructure

@aszlig
Copy link
Member

@aszlig aszlig commented on 0a6a063 Apr 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual cause for this is 89bfa11, so we need to improve the OCR detection.

@aszlig
Copy link
Member

@aszlig aszlig commented on 0a6a063 Apr 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shlevy: I've improved OCR detection and reverted this commit: c8c340b...5d5c0d5

Please sign in to comment.