Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsndfile: 1.0.27 -> 1.0.28 #24672

Merged
merged 1 commit into from Apr 8, 2017
Merged

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Apr 6, 2017

I've obviously not tested all binaries that depend on this change, but I've tested a few.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@magnetophon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @acowley and @lovek323 to be potential reviewers.

@FRidh FRidh changed the base branch from master to staging April 7, 2017 14:50
@Mic92
Copy link
Member

Mic92 commented Apr 7, 2017

Upgrade looks relatively safe: http://www.mega-nerd.com/libsndfile/NEWS

@aristidb aristidb merged commit f6fc846 into NixOS:staging Apr 8, 2017
@magnetophon magnetophon deleted the libsndfile branch January 25, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants