davmail: 4.7.2 -> 4.8.0 #24668
Merged
davmail: 4.7.2 -> 4.8.0 #24668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tosmi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vandenoever, @larkery and @aske to be potential reviewers. |
rasendubi
reviewed
Apr 6, 2017
There was a problem hiding this comment.
Looks good.
The only nitpick is nixpkgs guidelines require commit name to be davmail: 4.7.2 -> 4.8.0
|
sorry for that. saw the guidelines to late. should i amend the commit message? |
|
i've already changed the commit message |
tosmi
commented
Apr 6, 2017
| src = fetchurl { | ||
| url = "mirror://sourceforge/davmail/4.7.1/davmail-linux-x86_64-4.7.1-2416.tgz"; | ||
| sha256 = "196jr44kksb197biz984z664llf9z3d8rlnjm2iqcmgkjhx1mgy3"; | ||
| url = "mirror://sourceforge/davmail/4.7.1/davmail-linux-x86_64-4.8.0-2479.tgz"; |
There was a problem hiding this comment.
oops, the mirror url seems to be wrong, still points to 4.7.1. building works never the less as i'm running 4.8.0. i will change the url, re-test and rebase my commits.
|
sorry for the late response, i've fixed the path to the download url now and clean up my commits. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update davmail to version 4.8.0, running 4.8.0 locally on nixos 17.03.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)