ruby-modules: check tzinfo version #24682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzinfo 0.3.xx does not contain the file lib/tzinfo/zoneinfo_data_source.rb it is only included in the 1.x branch. closes NixOS#24080
|
@mguentner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cstrahan, @manveru and @aflatter to be potential reviewers. |
|
Looks good to me! |
LnL7
reviewed
Apr 6, 2017
| @@ -211,13 +211,13 @@ in | |||
| buildInputs = [ curl ]; | |||
| }; | |||
|
|
|||
| tzinfo = attrs: { | |||
| tzinfo = attrs: if lib.versionAtLeast attrs.version "1.0" then { | |||
There was a problem hiding this comment.
You can use stdenv.lib.optionalAttrs instead of the if statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
馃拵 馃拵 馃拵
tzinfo 0.3.xx does not contain the file
lib/tzinfo/zoneinfo_data_source.rb
it is only included in the 1.x branch.
closes #24080
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)